fix(realtime_client): Prevent sending expired tokens #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
changed the title
Vinzent03
requested changes
Dec 12, 2024
| null, | ||
| Level.FINE, | ||
| ); | ||
| throw FormatException( |
There was a problem hiding this comment.
the js client doesn't throw an exception, but logs the issue and then fails silently. I think it's better to not throw, because setAuth is used in other places, where they might re-set the same access token which is then expired, but it shouldn't throw in those cases. Or we add try catch to those cases.
There was a problem hiding this comment.
Great catch! I forgot to add, but the way js client handles the expired JWT changes in another PR though. supabase/realtime-js#439
Vinzent03
reviewed
Dec 12, 2024
Vinzent03
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a check of whether the JWT is expired before sending it to realtime. This helps the realtime logs to be filled with bunch of expired JWT token logs.
Equivalent of supabase/realtime-js#437 and partly supabase/realtime-js#439 from realtime-js